Skip to content

Adds a null check for items and threshold in inventory alert notification #18131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

Adds a null check for items and threshold in inventory alert notification #18131

merged 1 commit into from
Oct 30, 2025

Conversation

@Godmartinz
Copy link
Member

@Godmartinz Godmartinz commented Oct 30, 2025

This adds a null check on $items and $threshold. As you can null the threshold in settings. This should prevent a notification from firing if either are empty.

@Godmartinz Godmartinz requested a review from snipe as a code owner October 30, 2025 17:49
@Godmartinz Godmartinz changed the title add a null check for items and threshold in inventory alert notification Adds a null check for items and threshold in inventory alert notification Oct 30, 2025
@snipe snipe merged commit 6189501 into grokability:develop Oct 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Godmartinz @snipe